Change in vdsm[master]: BZ#773210 - Avoid infinite loop when delete volume failed du...

abaron at redhat.com abaron at redhat.com
Sun Apr 8 12:47:58 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#773210 - Avoid infinite loop when delete volume failed during the merge
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/image.py
Line 969:                 time.sleep(10)
So instead of failing the merge you'd keep the VM locked forever because the image is locked ?!?
Instead of raising you could log the problem and return without throwing an exception.
If you want to try many times then use retry and put 60 as the number of retries and 10s between each try:
try:
    misc.retry(func, expectedException=Exception, tries=60,
            timeout=None, sleep=10)
except Exception, e:
    self.log.warning(...)

--
To view, visit http://gerrit.ovirt.org/987
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1368141fb240c9ca4e3fb3cfad04f88312cc46b5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list