Change in vdsm[master]: BZ#809012 - Remove physical block size limitations.

abaron at redhat.com abaron at redhat.com
Sun Apr 8 12:35:00 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#809012 - Remove physical block size limitations.
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File vdsm/storage/multipath.py
Line 152:     return (logical, physical)
Correct, I missed that it's only logging, but it doesn't change things.  I still think we should call the validation method in blockSD.create.
And blockSD accepts a VG as param, if that VG was created outside of the context of vdsm (e.g. from command line) then no validation has been called.

--
To view, visit http://gerrit.ovirt.org/3284
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82630ff2964f875a2e135dad550eafca451af42d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>


More information about the vdsm-patches mailing list