Change in vdsm[master]: BZ#809012 - Remove physical block size limitations.

lyarwood at redhat.com lyarwood at redhat.com
Sun Apr 8 11:00:07 UTC 2012


Lee Yarwood has posted comments on this change.

Change subject: BZ#809012 - Remove physical block size limitations.
......................................................................


Patch Set 7: No score

(2 inline comments)

....................................................
File vdsm/constants.py.in
Line 39: SUPPORTED_BLOCKSIZE = (512,)
Correct, sorry I thought I had removed this, the actual check isn't required as we already check each PV above with :

 803     _checkpvsblksize(pvs)

....................................................
File vdsm/storage/multipath.py
Line 152:     return (logical, physical)
I'm not sure I follow Ayal, the function would only print an error message if the logical block size was different to the physical block size. I wouldn't call it validation.

IIRC we are reviewing the blocksizes _before_ calling blockSD.create() anyway.

--
To view, visit http://gerrit.ovirt.org/3284
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82630ff2964f875a2e135dad550eafca451af42d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>


More information about the vdsm-patches mailing list