Change in vdsm[master]: Added gluster support into vds bootstrap.

danken at redhat.com danken at redhat.com
Sat Apr 7 11:07:09 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Added gluster support into vds bootstrap.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vds_bootstrap/vds_bootstrap.py
Line 834:     global GLUSTER_PACK
the bootstrap code is an ugly pile of spaghetti, but that's not reason enough to modify a global CONSTANT within a function. Please find another way to pass the install_gluster boolean deeper into the stack.

Also please have new code with lines shorter than 80 chars, and with spaces after comas, and add yourself as an AUTHOR. Welcome, Timothy ;-)

--
To view, visit http://gerrit.ovirt.org/3351
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55636babe4bb789bf4744a83789906bd25213a0b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list