Change in vdsm[master]: BZ#773210 - Avoid infinite loop when delete volume failed du...

abaron at redhat.com abaron at redhat.com
Thu Apr 5 20:29:21 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#773210 - Avoid infinite loop when delete volume failed during the merge
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/storage/image.py
Line 969:                 time.sleep(10)
Sleep? really?
Why didn't you use retry as I asked on the previous review?
An infinite loop here is wrong, if we failed 3 times in a row there is no reason to believe number 4 would succeed...

--
To view, visit http://gerrit.ovirt.org/987
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1368141fb240c9ca4e3fb3cfad04f88312cc46b5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list