Change in vdsm[master]: Add pep8 checks to build process

danken at redhat.com danken at redhat.com
Thu Apr 5 20:26:43 UTC 2012


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Add pep8 checks to build process
......................................................................


Add pep8 checks to build process

This adds pep8 verification check. pep8 is the recommended styling for
python. The pep8 tester doesn't check all of the style recomendations
but it does help. Currently most of our code doesn't conform, so in
order to integrate it slowly there is a whitelist declared in
/Makefile.am.
When fixing a file to conform please add the file to the whitelist so
that after the patch is submitted the file will be tracked for
conformance.

More about pep8
http://www.python.org/dev/peps/pep-0008/

Change-Id: I77a2ae06467a676cf8b9574474852071599117ac
---
M Makefile.am
M configure.ac
M vdsm.spec.in
3 files changed, 13 insertions(+), 0 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Peter V. Saveliev: Verified; Looks good to me, but someone else must approve


--
To view, visit http://gerrit.ovirt.org/3259
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I77a2ae06467a676cf8b9574474852071599117ac
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list