Change in vdsm[master]: Remove rhevm from vds_bootstrap/

danken at redhat.com danken at redhat.com
Thu Apr 5 19:56:49 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Remove rhevm from vds_bootstrap/
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File vds_bootstrap/vds_bootstrap.py
Line 926:         print "<BSTRAP component='OVIRT_INSTALL' status='FAIL'/>"
We have customers with downstream Engine installed. If downstream vdsm-bootstrap includes your change as-is, host installation would fail. Old downstream Engine expects RHEV_INSTALL. This means that in order to work with it, downstream vdsm would have to undo your patch(es).

We could theoretically force the customer to upgrade to a newer Engine, with a smarter logic. However, customers don't like to be forced (and breaking API is evil). Also, someone would have to add logic to new Engine (I don't expect that you've sent a compatible patch to Engine, right?)

Now since I don't want RHEV trademarks cluttering vdsm code, I appreciate your help in their removal - but I'd politely ask you to make it easier for us to revert the API-breaking ones downstream.

--
To view, visit http://gerrit.ovirt.org/3287
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib28617f0fa45ff867fcd85eeb7bd49d8d5220d4d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ryan Harper <ryanh at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh at us.ibm.com>


More information about the vdsm-patches mailing list