Change in vdsm[master]: BZ#809012 - Remove physical block size limitations.

lyarwood at redhat.com lyarwood at redhat.com
Wed Apr 4 09:10:55 UTC 2012


Lee Yarwood has posted comments on this change.

Change subject: BZ#809012 - Remove physical block size limitations.
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File vdsm/storage/lvm.py
Line 896:         pvBlkSize = _getpvblksize(pv)
Dan I don't understand, do you want us to call _getpvblksize() three times in the same method?

Line 897:         logPvBlkSize, phyPvBlkSize = pvBlkSize
I'll add this back in and throw the generic DeviceBlockSizeError for now.

--
To view, visit http://gerrit.ovirt.org/3284
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82630ff2964f875a2e135dad550eafca451af42d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood <lyarwood at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Lee Yarwood <lyarwood at redhat.com>


More information about the vdsm-patches mailing list