Change in vdsm[master]: nfs-check improvements

danken at redhat.com danken at redhat.com
Tue Apr 3 19:56:56 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: nfs-check improvements
......................................................................


Patch Set 5: Looks good to me, approved

(1 inline comment)

....................................................
File contrib/nfs-check.py
Line 230:             errorMsg  = process.communicate()[1]
thanks for dropping the strip. it is just a matter of good practice: you created a general-purpose function to exec external apps. some apps have significant whitespace in stderrs. QED.

--
To view, visit http://gerrit.ovirt.org/3081
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I939476dbbad0f97b43b8dff4dc2c5913cb3d1a1e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>


More information about the vdsm-patches mailing list