Change in vdsm[master]: Add use domain proxies instead of actual domain references

ewoud at kohlvanwijngaarden.nl ewoud at kohlvanwijngaarden.nl
Tue Apr 3 10:58:16 UTC 2012


Ewoud Kohl van Wijngaarden has posted comments on this change.

Change subject: Add use domain proxies instead of actual domain references
......................................................................


Patch Set 5: Looks good to me, but someone else must approve

(1 inline comment)

Code looks good, but I'm not that familiar with it so I might be missing something.

....................................................
File vdsm/storage/sdc.py
Line 41:     (due to format conversion for example"""
Please close the parenthesis: http://xkcd.com/859/

--
To view, visit http://gerrit.ovirt.org/3044
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifdedd601ca25e6cac3f1f68f2917776401c0d838
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list