Change in vdsm[master]: Added register-to-engine command line tool.

dougsland at redhat.com dougsland at redhat.com
Tue Apr 3 02:00:13 UTC 2012


Douglas Schilling Landgraf has posted comments on this change.

Change subject: Added register-to-engine command line tool.
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm_reg/register-to-engine.py
Line 145:     sys.exit(SUCCESS)
Hello Bala.FA,

I am not sure if we should use sys.exit(SUCCESS) without verify if deployUtil.setService returns success or not. Sorry, just noticed that one right now re-reading the code.

--
To view, visit http://gerrit.ovirt.org/3113
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9b19ff95c99c11f1a4d4b5d224e5ddac25a5446
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list