Change in vdsm[master]: Integrate nosetests to vdsm testing

danken at redhat.com danken at redhat.com
Mon Apr 2 22:44:59 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Integrate nosetests to vdsm testing
......................................................................


Patch Set 2: Verified; I would prefer that you didn't submit this

(2 inline comments)

wow. finally.

....................................................
File tests/testrunner.py
Line 25: from nose import config
we should now BuildRequire: python-nose

or should we let skipping %check in `make rpm` ?

Line 29: COLORS = {"black": 30,
do we have to use misspellable strings as color names? I prefer the 'class' approach for enums, or even plain constants.

--
To view, visit http://gerrit.ovirt.org/3257
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c8d761ac0c03adf25324ea04e948b98faa82e39
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list