Change in vdsm[master]: BZ#807642 Use Securable as base class

danken at redhat.com danken at redhat.com
Mon Apr 2 09:10:29 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#807642 Use Securable as base class
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/storage/securable.py
Line 60:         if not (self._isSafe() or override):
I think that the problem with Securable runs even deeper than this race. Even if fixed, someone can call self._setUnsafe while f() is running, and nothing in Securable protects f from doing harm.

spmStop makes sure to not only _setUnsafe, but umount the master filesystem so we have some additional protection.

In any case, this issue should not be mixed with the current patch.

--
To view, visit http://gerrit.ovirt.org/3198
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2309e2cfc0291309023238ed91527884ec879d64
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list