Change in vdsm[master]: BZ#808116 - Fix post-zeroing process during deletion of prea...

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Apr 1 15:21:59 UTC 2012


Eduardo has posted comments on this change.

Change subject: BZ#808116 - Fix post-zeroing process during deletion of preallocated volumes
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

(2 inline comments)

....................................................
File vdsm/storage/blockVolume.py
Line 706:         if lv.name in lvNames:
TODO: Should warn if len(lvm.getLV) < len(lvNames), meaning that required volumes were not zeroed.
Use sets.

....................................................
File vdsm/storage/hsm.py
Line 1260:         vars.task.getExclusiveLock(STORAGE, imgUUID)
TODO: This lock should be taken in the other hsm image related functions.

--
To view, visit http://gerrit.ovirt.org/3207
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia594ae7bea92754f25a5568e1c20a6891ff0eca5
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list