Change in vdsm[master]: fix masterVersion 0 err when connecting storage pool

ewarszaw at redhat.com ewarszaw at redhat.com
Sun Apr 1 15:01:26 UTC 2012


Eduardo has posted comments on this change.

Change subject: fix masterVersion 0 err when connecting storage pool
......................................................................


Patch Set 2: I would prefer that you didn't submit this

Royce Lv why is this patch required?
Do you have a script driving this condition to occur?

masterVersion should be >= 1 on any master domain.
When connecting to a pool, the manager knows and sends the masterVersion.
-1 is only used in vdsClient and should be fixed.

There are parts of the code assuming that masterVersion = 0 is for regular, e.g. no master, domains.

--
To view, visit http://gerrit.ovirt.org/2679
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7228bd340a4281400e16c26b311d9945dd5ce597
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list