Change in vdsm[master]: Define some constants in API.py

danken at redhat.com danken at redhat.com
Sun Apr 1 13:51:32 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: Define some constants in API.py
......................................................................


Patch Set 4: Looks good to me, but someone else must approve

(2 inline comments)

approach looks good to me, but 2 minor questions within.

....................................................
File vdsm/API.py
Line 760:     DEFAULT_VERSION = storage.sd.DOM_SAFELEASE_VERS[0]
why would we want DEFAULT_VERSION exposed in the API?

Line 945:     MAX_HOST_ID = storage.safelease.MAX_HOST_ID
pardon, but why this has to be exposed to Vdsm API users?

--
To view, visit http://gerrit.ovirt.org/2262
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef19f956ec1d6f83fd48e71a2f0a018505266be
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list