Change in vdsm[master]: BZ#740887 Tune cache dirty ratio
danken at redhat.com
danken at redhat.com
Tue Sep 27 14:25:45 UTC 2011
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#740887 Tune cache dirty ratio
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
Commit Message
Line 3: AuthorDate: 2011-09-26 15:28:36 +0000
Line 4: Commit: Federico Simoncelli <fsimonce at redhat.com>
Line 5: CommitDate: 2011-09-26 15:32:34 +0000
Line 6:
Line 7: BZ#740887 Tune cache dirty ratio
Could you explain why we need to do it? bugzilla does not give to much, either.
Line 8:
Line 9: Change-Id: Ibf5c8e4c0637c60092b89fba103b96b37bdafaa0
Line 10
Line 11
....................................................
File vdsm/clientIF.py
Line 143: self.irs.prepareForShutdown()
Line 144: raise
Line 145:
Line 146: def _tuneDirtyRatio(self):
Line 147: storage.misc.setDirtyRatio(config.get('vars', 'dirty_ratio'))
storage.misc? why? and if so, it should be [irs] section, probably.
Line 148: storage.misc.setDirtyBackgroundRatio(
Line 149: config.get('vars', 'dirty_background_ratio'))
Line 150:
Line 151: def _getServerIP(self):
--
To view, visit http://10.35.18.144/970
To unsubscribe, visit http://10.35.18.144/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf5c8e4c0637c60092b89fba103b96b37bdafaa0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
More information about the vdsm-patches
mailing list