Change in vdsm[master]: Don't use a list to calculate VG size
Federico Simoncelli
fsimonce at redhat.com
Mon Sep 26 05:55:20 UTC 2011
Federico Simoncelli has posted comments on this change.
Change subject: Don't use a list to calculate VG size
......................................................................
Patch Set 1: (2 inline comments)
....................................................
Commit Message
Line 3: AuthorDate: 2011-09-22 13:39:44 +0000
Line 4: Commit: Federico Simoncelli <fsimonce at redhat.com>
Line 5: CommitDate: 2011-09-22 13:40:10 +0000
Line 6:
Line 7: Don't use a list to calculate VG size
I don't think it's worth a backport.
Line 8:
Line 9: Change-Id: Ief2a3e69f94c99b11c9027901fc5a34577c3452f
Line 10
Line 11
....................................................
File vdsm/storage/hsm.py
Line 840:
Line 841: vars.task.setDefaultException(se.VolumeGroupCreateError(str(vgname), str(devlist)))
Line 842: misc.validateUUID(vgname, 'vgname')
Line 843: #getSharedLock(connectionsResource...)
Line 844: knowndevs = list(multipath.getMPDevNamesIter())
Ok I'll add this too.
Line 845: size = 0
Line 846: devices = []
Line 847:
Line 848: for dev in devlist:
--
To view, visit http://10.35.18.144/967
To unsubscribe, visit http://10.35.18.144/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief2a3e69f94c99b11c9027901fc5a34577c3452f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>
More information about the vdsm-patches
mailing list