Change in vdsm[master]: Don't use a list to calculate VG size

danken at redhat.com danken at redhat.com
Fri Sep 23 10:31:58 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Don't use a list to calculate VG size
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/storage/hsm.py
Line 840: 
Line 841:         vars.task.setDefaultException(se.VolumeGroupCreateError(str(vgname), str(devlist)))
Line 842:         misc.validateUUID(vgname, 'vgname')
Line 843:         #getSharedLock(connectionsResource...)
Line 844:         knowndevs = list(multipath.getMPDevNamesIter())
I think it's more urgent to make a set() out of this list()...
Line 845:         size = 0
Line 846:         devices = []
Line 847: 
Line 848:         for dev in devlist:


--
To view, visit http://gerrit.usersys.redhat.com/967
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief2a3e69f94c99b11c9027901fc5a34577c3452f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list