Change in vdsm[master]: BZ#735725 - Streamline configuration settin

danken at redhat.com danken at redhat.com
Tue Sep 20 11:10:37 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#735725 - Streamline configuration settin
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

I am a bit worried about such a rewrite in our stage. I also think that the proper way of doing this is to use augeas.

If you prefer a little hack for RHEV 3.0, appending key=value is less intrusive.

....................................................
File vdsm_reg/deployUtil.py.in
Line 656:             return False
Line 657:     else:
Line 658:         config.set(section, option, value)
Line 659: 
Line 660:     safeConfigWrite(config, fileName, fileStat)
do you want to return None here?
Line 661: 
Line 662: #############################################################################################################
Line 663: # Host bridge functions.
Line 664: #############################################################################################################


--
To view, visit http://gerrit.usersys.redhat.com/960
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37083a3acef3d3720d2a55a18c8a73550becf6ff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list