Change in vdsm[master]: BZ#732416 fix deleteMultipleVolumes().
danken at redhat.com
danken at redhat.com
Tue Sep 20 05:38:01 UTC 2011
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#732416 fix deleteMultipleVolumes().
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/storage/image.py
Line 208:
Line 209: # If we got here than go ahead and remove all of them without mercy
Line 210: if volumes:
Line 211: try:
Line 212: #No, this is not a classmethod! No validations here
has this cryptic comment rotten? do you understand it? Please fix or remove.
Line 213: mod = __import__(volclass.__module__, fromlist = ["deleteMultipleVolumes"])
Line 214: mod.deleteMultipleVolumes(sdUUID, volumes, postZero)
Line 215: except (se.CannotRemoveLogicalVolume, se.VolumeAccessError):
Line 216: #Any volume deletion failed, but we don't really care at this point
Line 209: # If we got here than go ahead and remove all of them without mercy
Line 210: if volumes:
Line 211: try:
Line 212: #No, this is not a classmethod! No validations here
Line 213: mod = __import__(volclass.__module__, fromlist = ["deleteMultipleVolumes"])
why the fromlist? I do not see any effect of it. (and no spaces in front of named args)
Line 214: mod.deleteMultipleVolumes(sdUUID, volumes, postZero)
Line 215: except (se.CannotRemoveLogicalVolume, se.VolumeAccessError):
Line 216: #Any volume deletion failed, but we don't really care at this point
Line 217: self.log.warn("Problems during image %s deletion (%s). Continue...", exc_info=True)
....................................................
File vdsm/storage/lvm.py
Line 786: log.info("deactivate vg %s failed: rc %s - %s %s (ignored)" % (vgs, rc, out, err))
Line 787: else:
Line 788: raise se.VolumeGroupActionError("vgchange on vg(s) %s failed. %d %s %s" % (vgs, rc, out, err))
Line 789:
Line 790: def changelv(vg, lvs, attrName, attrValue):
actually, there is one! in blockVolume._postZero()
Line 791: # Note:
Line 792: # You may activate an activated LV without error
Line 793: # but lvchange returns an error (RC=5) when activating rw if already rw
Line 794: lvs = _normalizeargs(lvs)
--
To view, visit http://gerrit.usersys.redhat.com/943
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I03cd1cb2227b31b2e2d7e2e1c13cee5318ce76e2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Max Benenson <mbenenso at redhat.com>
More information about the vdsm-patches
mailing list