Change in vdsm[master]: BZ#736154 - Add rhevm_admin_password kernel param
danken at redhat.com
danken at redhat.com
Tue Sep 13 12:59:23 UTC 2011
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#736154 - Add rhevm_admin_password kernel param
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
I like full paths, though.
....................................................
File vdsm_reg/vdsm-config
Line 110: echo "rhevm_admin_password: $rhevm_admin_password" >> $LOG 2>&1
it is very uncommon to log passwords. do we want that?
Line 112: /usr/sbin/usermod -p "$rhevm_admin_password" root
to keep ykaul happier?
--
To view, visit http://gerrit.usersys.redhat.com/932
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibae326f6ce0358cfeb23fef5f75f9ebb41dcb679
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>
More information about the vdsm-patches
mailing list