Change in vdsm[master]: [WIP] Replace SPM domain locks with Sanlock

Federico Simoncelli fsimonce at redhat.com
Tue Sep 13 10:41:20 UTC 2011


Federico Simoncelli has posted comments on this change.

Change subject: [WIP] Replace SPM domain locks with Sanlock
......................................................................


Patch Set 2: (6 inline comments)

....................................................
File vdsm/storage/blockSD.py
Line 593:         lvm.activateLVs(self.sdUUID, [sd.IDS])
Where should I activate? Look few lines below: _getLeasesFilePath.

....................................................
File vdsm/storage/safelease.py
Line 93: class ClusterLock(object):
We know this, I'm waiting for instruction about how to integrate this in the existing datacenters. At the moment this is useful for testing (and comparison with old code).

Line 108:     def initLock(self):
A new ClusterLock object is instantiated every time you connect to a domain. That doesn't mean you need to "init" it every time. It's needed only the first time. This is part of the current API of ClusterLock. (Look at the old implementation up above).

....................................................
File vdsm/storage/sd.py
Line 333:     def initSPMlease(self):
See the initLock comment.

....................................................
File vdsm/storage/sp.py
Line 281:             self.id = 250
This is a phony id we use to take actions on a domain that is not connected to any pool yet (eg: on creation).

....................................................
File vdsm/storage/storage_exception.py
Line 1172:     message = "Cannot obtain lock"
I don't know. I simply changed "Could not" to "Cannot" for consistency.

--
To view, visit http://gerrit.usersys.redhat.com/678
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3958a171e35d65544e0f2c3593daaf7daf8750ef
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list