Change in vdsm[master]: [WIP] Replace SPM domain locks with Sanlock

Yotam Oron yoron at redhat.com
Tue Sep 13 10:24:29 UTC 2011


Yotam Oron has posted comments on this change.

Change subject: [WIP] Replace SPM domain locks with Sanlock
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(4 inline comments)

....................................................
File vdsm/storage/safelease.py
Line 108:     def initLock(self):
This function seems redundant.
It can be merged into the __init__ and the calls to it can be removed.

....................................................
File vdsm/storage/sd.py
Line 333:     def initSPMlease(self):
If you remove initLock from safelease.py, this function can go away too.

....................................................
File vdsm/storage/sp.py
Line 281:             self.id = 250
This is possible since we can only be connected to one pool, right ?

....................................................
File vdsm/storage/storage_exception.py
Line 1172:     message = "Cannot obtain lock"
Why 'obtain' and not 'acquire' ?

--
To view, visit http://gerrit.usersys.redhat.com/678
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3958a171e35d65544e0f2c3593daaf7daf8750ef
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list