[NEW PATCH] Related to 726960 - Restore higher version check. (via gerrit-bot)

Eduardo Warszawski ewarszaw at redhat.com
Mon Sep 12 19:51:38 UTC 2011


New patch submitted by Eduardo Warszawski (ewarszaw at redhat.com)

You can review this change at: http://gerrit.usersys.redhat.com/927

commit 226507fe5408e92522d98179410cfbc8e7c4a3fd
Author: Eduardo Warszawski <ewarszaw at redhat.com>
Date:   Mon Sep 12 16:17:06 2011 +0300

    Related to 726960 - Restore higher version check.
    
    This check was removed in commit 85b58b7d9 since the manager
    can't send a lower pool version number.
    In spite of this some tests stress this condition.
    Restoring it in order to fix tests results.
    
    Change-Id: I9c7258361589fac7dc94361b88cabdf73cf48a83

diff --git a/vdsm/storage/sp.py b/vdsm/storage/sp.py
index bec3beb..e6a3107 100644
--- a/vdsm/storage/sp.py
+++ b/vdsm/storage/sp.py
@@ -628,6 +628,8 @@ class StoragePool:
 
         # Check if we are migrating to or just unmounting last master
         if msdUUID != sd.BLANK_UUID:
+            # TODO: is this check relevant?
+            self.validatePoolMVerHigher(masterVersion)
             self.__masterMigrate(sdUUID, msdUUID, masterVersion)
             return False    # not last master
 




More information about the vdsm-patches mailing list