Change in vdsm[master]: Revert "BZ#717847 - Postpone VM's periodic tasks until all v...

Igor Lvovsky ilvovsky at redhat.com
Mon Sep 12 19:09:04 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: Revert "BZ#717847 - Postpone VM's periodic tasks until all volumes are prepared"
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 81:         if not self._vm.cif.irs.getConnectedStoragePoolsList()['poollist']:
getConnectedStoragePoolsList will issue a lot of unnecessary queries, so I think in this particular case (if you will decided at the end to remove _volumesPrepared from others locations) we still need some flag to mark finish of volume preparation ( _volumesPrepared did exactly this thing)

--
To view, visit http://gerrit.usersys.redhat.com/928
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78be7a2f008a88d400db5c3e218e8c043b222cec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list