Change in vdsm[master]: BZ#730778 - Add timeout when acquiring resources in prepareV...

danken at redhat.com danken at redhat.com
Mon Sep 12 15:43:00 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#730778 - Add timeout when acquiring resources in prepareVolume
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

....................................................
File vdsm/config.py
Line 162: config.set('irs', 'prepare_image_timeout', '6000000')
didn't we agree about 10 minutes?
I see here 100 minutes.

....................................................
File vdsm/storage/hsm.py
Line 1702:         timeout = config.getint('irs', 'prepare_image_timeout') / 1000
1000.0

(we do not really care for milliseconds in this timeout, but let's avoid unneeded rounding, and keep consistent with resourceFactory.py)

we ALL missed that on the former patch you've passed milliseconds as seconds..

--
To view, visit http://gerrit.usersys.redhat.com/859
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bbe6ea0ff82a4af3c728f520546870324363c44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list