Change in vdsm[master]: BZ#725967 - Have global pool users use the limiter as well

danken at redhat.com danken at redhat.com
Mon Sep 12 14:54:43 UTC 2011


Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#725967 - Have global pool users use the limiter as well
......................................................................


BZ#725967 - Have global pool users use the limiter as well

In the last patch in the quest for using only 1 storage pool I left out
the global pool users. Because the global pool was initialized on import
because after this patch all the handlers are created at once this
caused all the handlers to be created on import. This made the pool act
strange on certain occasions. The fact that the global users didn't pass
through the limiter was a mistake in itself.

This patch:
* Moves ProcessPoolLimiter to the processPool module because it is
  the correct place and I didn't want all the global pool users
  importing sd.py.
* Removes ProcessPoolDict and creates a new class called
  ProcessPoolMultiplexer that does the same thing but does not inherit
  from dict which means you don't get the __set__ methods and other
  garbage. It also moves the logic to the processPool module.
* Adds getProcessPool() to outOfProcess so there is convenient access
  to the global multiplexer.
* Adds getGlobalProcPool() to outOfProcess so global pool users can get
  the global pool on demand and not on import
* Changes all calls to the global process pool to go through the
  aforementioned methods so that the pool is never created on import

Change-Id: Id52f872b3bfd12088a601f69678a602d4c6f3c76
---
M vdsm/storage/fileSD.py
M vdsm/storage/fileVolume.py
M vdsm/storage/nfsSD.py
M vdsm/storage/outOfProcess.py
M vdsm/storage/processPool.py
M vdsm/storage/sd.py
M vdsm/storage/storage_connection.py
M vdsm/storage/task.py
M vdsm/vdsm
9 files changed, 124 insertions(+), 147 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.usersys.redhat.com/910
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id52f872b3bfd12088a601f69678a602d4c6f3c76
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list