Change in vdsm[master]: BZ#725967 - Have global pool users use the limiter as well

danken at redhat.com danken at redhat.com
Mon Sep 12 14:43:48 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#725967 - Have global pool users use the limiter as well
......................................................................


Patch Set 5: Verified; Looks good to me, approved

(1 inline comment)

....................................................
File vdsm/storage/outOfProcess.py
Line 39: def getProcessPool(clientName):
I hate using the pointer trick when the "global" statement serves you right. It confuses the reader to think that you are doing something complex, when you are not.

--
To view, visit http://gerrit.usersys.redhat.com/910
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id52f872b3bfd12088a601f69678a602d4c6f3c76
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list