Change in vdsm[master]: Use python -m to load supervdsmserver

Yotam Oron yoron at redhat.com
Mon Sep 12 09:54:35 UTC 2011


Yotam Oron has posted comments on this change.

Change subject: Use python -m to load supervdsmserver
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm/supervdsm.py
Line 37: 
Please make sure that RHEVH works with this patch.

Line 73:         pythonpath = os.path.abspath(os.path.dirname(__file__))
What is supervdsmServer and this file are not in the same directory ?

Line 74:         superVdsmCmd = [constants.EXT_ENV, 'PYTHONPATH=%s' % pythonpath, constants.EXT_PYTHON, "-m", "supervdsmServer",
Line is longer than 80 chars.

--
To view, visit http://gerrit.usersys.redhat.com/870
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ad081631512896ed1be658328b318984d6c8ff1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list