Change in vdsm[master]: [WIP] Initial DRBD implementation

Saggi Mizrahi smizrahi at redhat.com
Sun Sep 11 08:14:16 UTC 2011


Saggi Mizrahi has posted comments on this change.

Change subject: [WIP] Initial DRBD implementation
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/storage/drbd.py
Line 84:         return "%016X" % (random.randint(0, DRBD_MAXUUID),)
I would rater you somehow hash a real uuid or mangle time() into it.

Line 109:             uuid = cls.readUUID(device)
This is racefull, just try and if you fail find out why

--
To view, visit http://gerrit.usersys.redhat.com/923
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I33bb867ba6c7cfca54d31334554cb37db11aeeea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list