Change in vdsm[master]: Don't override the rpm topdir macro settings

danken at redhat.com danken at redhat.com
Thu Sep 8 19:37:19 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: Don't override the rpm topdir macro settings
......................................................................


Patch Set 4: Looks good to me, approved

(1 inline comment)

....................................................
File Makefile.am
Line 25: 	rpmbuild -ta --define="extra_release $(BUILDID)" $(DIST_ARCHIVES)
unrelated to this patch, but we see an ugly warning when -z $BUILDID. consider quoting.

--
To view, visit http://gerrit.usersys.redhat.com/826
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia84386fb980745107c7d664900effcbc0bb2d18e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list