Change in vdsm[master]: [WIP] Use vdsm-tool to install sudoers
David Naori
dnaori at redhat.com
Thu Sep 8 19:15:25 UTC 2011
David Naori has posted comments on this change.
Change subject: [WIP] Use vdsm-tool to install sudoers
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File vdsm/vdsm-tool
Line 51: ret = os.system("visudo -q -c -f '%s'" % (SUDOERS_LOCK,))
why not subprocess?
Line 116: # vim: set et ts=4 :
# vim? :]
why isn't this file with .py suffix? its colorless
--
To view, visit http://gerrit.usersys.redhat.com/912
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b1bd8b9b9307d867661dd5df698ce7ecc6b4843
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list