Change in vdsm[master]: BZ#736154 - Add root password configuration option in the rh...

David Naori dnaori at redhat.com
Thu Sep 8 18:31:56 UTC 2011


David Naori has posted comments on this change.

Change subject: BZ#736154 - Add root password configuration option in the rhevm tab
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm_reg/rhevm.py
Line 182:             devNull = file('/dev/null', 'w+')
do you need to open /dev/null for reading?

--
To view, visit http://gerrit.usersys.redhat.com/913
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7347afde1656713bc9a455da784aad0e76660f4b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Joey Boggs <jboggs at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list