Change in vdsm[master]: Related to BZ#732416 - Unify criteria for active LV in lvm c...

Saggi Mizrahi smizrahi at redhat.com
Thu Sep 8 11:40:40 UTC 2011


Saggi Mizrahi has posted comments on this change.

Change subject: Related to BZ#732416 - Unify criteria for active LV in lvm cache.
......................................................................


Patch Set 3: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File vdsm/storage/lvm.py
Line 985:         #Fix me
it should be "#FIXME : Should not remove active LVs"
this will not be caught by common greppers

--
To view, visit http://gerrit.usersys.redhat.com/873
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91506ed397512e51ba5560fbb617e853668ebc0e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list