Change in vdsm[master]: A new JSON-based protocol with the guest's agent.
Saggi Mizrahi
smizrahi at redhat.com
Wed Sep 7 15:12:02 UTC 2011
Saggi Mizrahi has posted comments on this change.
Change subject: A new JSON-based protocol with the guest's agent.
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(2 inline comments)
Minor issues, fix if someone gives -1
....................................................
File vdsm/clientIF.py
Line 840: Send a command to the guest agent (depricated).
deprecated
....................................................
File vdsm/guestIF.py
Line 202: self.log.debug("sendHcCmdToDesktop('%s')"%(cmd))
Formatting should be done by the logger
Vdsm already logs the name of the function automatically there is no need to log it again
--
To view, visit http://gerrit.usersys.redhat.com/807
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6096b326cc58879c8f63b72e32586657fffeca0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
More information about the vdsm-patches
mailing list