Change in vdsm[master]: [WIP] Replace SPM domain locks with Sanlock

Eduardo Warszawski ewarszaw at redhat.com
Wed Sep 7 12:33:44 UTC 2011


Eduardo Warszawski has posted comments on this change.

Change subject: [WIP] Replace SPM domain locks with Sanlock
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(2 inline comments)

Only partial comments.

....................................................
File vdsm/storage/blockSD.py
Line 593:         lvm.activateLVs(self.sdUUID, [sd.IDS])
Please don't activate here.

....................................................
File vdsm/storage/safelease.py
Line 93: class ClusterLock(object):
This is a redefinition of ClusterLock class.
Remove the 1st or change the name.

--
To view, visit http://gerrit.usersys.redhat.com/678
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3958a171e35d65544e0f2c3593daaf7daf8750ef
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list