Change in vdsm[master]: A new JSON-based protocol with the guest's agent.

danken at redhat.com danken at redhat.com
Wed Sep 7 11:53:29 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: A new JSON-based protocol with the guest's agent.
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/clientIF.py
Line 292:                 (self.sendCmdToDesktop, 'sendCmdToDesktop'),
please do not change the API name in this patch. The new name is actually worse than the former one, btw.

--
To view, visit http://gerrit.usersys.redhat.com/807
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6096b326cc58879c8f63b72e32586657fffeca0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list