Change in vdsm[master]: A new JSON-based protocol with the guest's agent.

Gal Hammer ghammer at redhat.com
Wed Sep 7 11:38:36 UTC 2011


Gal Hammer has posted comments on this change.

Change subject: A new JSON-based protocol with the guest's agent.
......................................................................


Patch Set 4: (5 inline comments)

....................................................
File vdsm/guestIF.py
Line 83:                 old_ips += ' '.join(iface['inet']) + ' '
Done

Line 182:         if self.guestStatus not in ("Powered down", "RebootInProgress"):
Why? It is used only here and doesn't have a special meaning. Also this is an old code and fixing this should be included in another patch.

Line 196:                 time.sleep(1)
I don't think so. The _readBuffer function is the wrapping method of socket.recv.

Line 222:             except:
Done

Line 235:                 if message:
Redundant as the code was change to throw exception on error.

--
To view, visit http://gerrit.usersys.redhat.com/807
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6096b326cc58879c8f63b72e32586657fffeca0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list