Change in vdsm[master]: BZ#732980 Devices block size must be 512

Saggi Mizrahi smizrahi at redhat.com
Wed Sep 7 08:17:52 UTC 2011


Saggi Mizrahi has posted comments on this change.

Change subject: BZ#732980 Devices block size must be 512
......................................................................


Patch Set 5: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm/storage/blockSD.py
Line 520:                             "VG devices block size must be 512")
Move text to storage_exception and use
must be any of %s", constants.SUPPORTED_BLOCKSIZES

....................................................
File vdsm/storage/hsm.py
Line 762:                         'logicalblocksize': dev.get("logicalblocksize", ""),
maybe logical_block_size or logicalBlockSize?

Line 858:                     "All devices in domain must have the same block size")
Use another error code so mgmt can know the difference

--
To view, visit http://gerrit.usersys.redhat.com/855
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If303fac85a29bed7b989b0b6302fc4c83075f500
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list