Change in vdsm[master]: BZ#732914 Check libvirt connection on startup
danken at redhat.com
danken at redhat.com
Tue Sep 6 20:32:44 UTC 2011
Dan Kenigsberg has posted comments on this change.
Change subject: BZ#732914 Check libvirt connection on startup
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(4 inline comments)
....................................................
Commit Message
Line 7: BZ#732914 Check libvirt connection on startup
more exactly: establish libvirt connection on startup
crash vdsm asap if libvirt is not available.
....................................................
File vdsm/clientIF.py
Line 115: self.libvirt = libvirtconnection.get(self)
any reason this is not _private?
Line 116: self._initIRS()
I think there's a little race here. you pass `self` to libvirtconnection.get() before all fields are defined. If prepareForshutdown is called from get() we'll see ugly exceptions. I suppose using a plain libvirtconnection.get() will be safer and as useful to crash __init__.
hmmm, maybe even push it to libvirtconnection.py import time.
Line 980: domIds = self.libvirt.listDomainsID()
no.
--
To view, visit http://gerrit.usersys.redhat.com/896
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I913acefd3d41bc34e831783687f287d92c7aa282
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
More information about the vdsm-patches
mailing list