Change in vdsm[master]: BZ#726400 - Remove lvm operations from StoragePool.__rebuild...

danken at redhat.com danken at redhat.com
Tue Sep 6 15:14:54 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#726400 - Remove lvm operations from StoragePool.__rebuild().
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 868:         #Add the block domains
add FIXME here; blockDomUUIDs may include file domains that currently are not seen.

also, explain this in commit message: this function may create false directories under
/rhev/data-center/mnt/blockSD/
it should not cause any other ill-effects since nothing would point to them.

--
To view, visit http://gerrit.usersys.redhat.com/832
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I712d57d3d16aba5e394ed42f247b14cf86c44b2d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list