Change in vdsm[master]: Related to BZ#732275 - Remove verifyMasterDomain().

Igor Lvovsky ilvovsky at redhat.com
Tue Sep 6 15:09:36 UTC 2011


Igor Lvovsky has posted comments on this change.

Change subject: Related to BZ#732275 - Remove verifyMasterDomain().
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(4 inline comments)

....................................................
File vdsm/storage/sp.py
Line 834:             self.masterDomain = self.getMasterDomain(msdUUID=msdUUID, masterVersion=masterVersion)
You return tuple in getMasterDomain below

Line 837:             raise se.StoragePoolMasterNotFound(self.spUUID, "%s_%s" % (msdUUID, masterVersion))
don't pass masterVersion here it's redundant.
maybe log with traceback?

Line 1122:         'spUUID' - storage pool UUID
Fix parameters in docstring

Line 1141:         self.log.debug("Master domain %s verified, version ", msdUUID, masterVersion)
you missed %d for version

--
To view, visit http://gerrit.usersys.redhat.com/903
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6284fbaf1716b99182c75630e0d3ad17a09b69ba
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>


More information about the vdsm-patches mailing list