Change in vdsm[master]: BZ#735932 vds_bootstrap: do not download and do not use redh...

Saggi Mizrahi smizrahi at redhat.com
Tue Sep 6 11:19:10 UTC 2011


Saggi Mizrahi has posted comments on this change.

Change subject: BZ#735932 vds_bootstrap: do not download and do not use redhat-lsb
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm_reg/deployUtil.py.in
Line 362:             s = file('/etc/redhat-release').read()
Should be file(f)

Line 367:         return islice(dropwhile(lambda x: x!='release', s.split()),
spaces between operator

Line 370:         logging.error('failed to parse os release from `%s`.', exc_info=True)
%s will never be filled

--
To view, visit http://gerrit.usersys.redhat.com/898
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6f0bb85b126a4471dfd63e46bebad229c28a4f9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list