Change in vdsm[master]: A new JSON-based protocol with the guest's agent.

danken at redhat.com danken at redhat.com
Mon Sep 5 16:28:32 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: A new JSON-based protocol with the guest's agent.
......................................................................


Patch Set 4: (3 inline comments)

....................................................
File vdsm/guestIF.py
Line 9: def _filterXmlChars(u):
I do not know why, but xmlcharrefreplace accepts '\x01' and some of its other friends, which the spec frowns upon.

Line 15:     restricted = set(range(8+1)).union(
correct (here and later). the impl is silly. but fixing it is for another patch.

Line 222:             except:
I think it's better to put try:except: in the while loop, and never return (None, None) from this function.

--
To view, visit http://gerrit.usersys.redhat.com/807
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6096b326cc58879c8f63b72e32586657fffeca0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list