Change in vdsm[master]: BZ#733910 - Clean links in directories in __cleanStorageRepo...

danken at redhat.com danken at redhat.com
Mon Sep 5 15:17:24 UTC 2011


Dan Kenigsberg has submitted this change and it was merged.

Change subject: BZ#733910 - Clean links in directories in __cleanStorageRepository
......................................................................


BZ#733910 - Clean links in directories in __cleanStorageRepository

os.walk() sees links to directories as directories, so the code
tries to delete the links with rmdir(), fails, and then the consequent
rmdir() of the parent dir also fails since the directory is not empty.
Instead of rmdir(), unlink() a link.

Change-Id: I0bd54dcca2b73f0f371aae4d6952a0da137c25db
---
M vdsm/storage/hsm.py
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved


--
To view, visit http://gerrit.usersys.redhat.com/858
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0bd54dcca2b73f0f371aae4d6952a0da137c25db
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list