Change in vdsm[master]: A new JSON-based protocol with the guest's agent.

Saggi Mizrahi smizrahi at redhat.com
Mon Sep 5 14:44:51 UTC 2011


Saggi Mizrahi has posted comments on this change.

Change subject: A new JSON-based protocol with the guest's agent.
......................................................................


Patch Set 4: I would prefer that you didn't submit this

(7 inline comments)

....................................................
File vdsm/guestIF.py
Line 9: def _filterXmlChars(u):
Why not use XmlCharReplace from python
http://docs.python.org/howto/unicode.html

Line 15:     restricted = set(range(8+1)).union(
Should be a constant generated only once

Line 19:                  set(range(0x86,0x9F+1)))
Give a breather line before functions

Line 24:     return ''.join([maskRestricted(c) for c in u])
Don't use list comprehension, without the [] it'll create an iterator which will not create a list just to concatenate it.

Line 182:         if self.guestStatus not in ("Powered down", "RebootInProgress"):
Constants ^^^

Line 196:                 time.sleep(1)
The sleep shouldn't be handled in this function. It should be handled by the wrapping methods.

Line 235:                 if message:
is None

--
To view, visit http://gerrit.usersys.redhat.com/807
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6096b326cc58879c8f63b72e32586657fffeca0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list