Change in vdsm[master]: BZ#602338 - Reset vdsm-reg conf file on certificate fingerpr...

danken at redhat.com danken at redhat.com
Mon Sep 5 08:13:44 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: BZ#602338 - Reset vdsm-reg conf file on certificate fingerprint verification failure
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File vdsm_reg/vdsm-config
Line 75: 			cp /etc/vdsm-reg/vdsm-reg.conf /tmp/vdsm-reg.conf.org
I think it would be nicer to use `mktemp`. It is more robust, and will help with the case of a missing vdsm-reg.conf --- current code will fail to reset it in line 91.

--
To view, visit http://gerrit.usersys.redhat.com/890
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I394007e7794dd901356c7f9b582c682e6bfcf325
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yotam Oron <yoron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yotam Oron <yoron at redhat.com>


More information about the vdsm-patches mailing list