Change in vdsm[master]: A new JSON-based protocol with the guest's agent.

Gal Hammer ghammer at redhat.com
Sun Sep 4 07:18:11 UTC 2011


Gal Hammer has posted comments on this change.

Change subject: A new JSON-based protocol with the guest's agent.
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File vdsm/guestIF.py
Line 83:                 old_ips += ' '.join(iface['inet']) + ' '
If you want to call an extra space a change in the API then yes.

Line 222:             except:
I'm sorry. I didn't understand what you want me to change.

--
To view, visit http://gerrit.usersys.redhat.com/807
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6096b326cc58879c8f63b72e32586657fffeca0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list