Change in vdsm[master]: A new JSON-based protocol with the guest's agent.

danken at redhat.com danken at redhat.com
Thu Sep 1 21:51:33 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: A new JSON-based protocol with the guest's agent.
......................................................................


Patch Set 4: (2 inline comments)

....................................................
File vdsm/guestIF.py
Line 83:                 old_ips += ' '.join(iface['inet']) + ' '
but it is a (small) change in vdsm API, right?

Line 222:             except:
I meant catching the exception in a more external context, instead of swollowing it here and hiding it as a returned (None, None). The fact that Python allows dynamic typing does not mean that it is a good practice to use it...

oops, missed the exception().

--
To view, visit http://gerrit.usersys.redhat.com/807
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6096b326cc58879c8f63b72e32586657fffeca0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Naori <dnaori at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>


More information about the vdsm-patches mailing list